This repository was archived by the owner on Feb 2, 2025. It is now read-only.
forked from crossplane/oam-kubernetes-runtime
-
Notifications
You must be signed in to change notification settings - Fork 0
VZ-8104 make user numeric in Dockerfile #1
Open
mbenmclean
wants to merge
39
commits into
oracle/release/0.3.3
Choose a base branch
from
mbenmclean/vz-8104-numeric-user
base: oracle/release/0.3.3
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mark Nelson <mark.x.nelson@oracle.com>
Signed-off-by: Mark Nelson <mark.x.nelson@oracle.com>
Signed-off-by: Mark Nelson <mark.x.nelson@oracle.com>
Signed-off-by: Mark Nelson <mark.x.nelson@oracle.com>
* update docker file given base image update
VZ 3778: OAM SDK 1.22 compat
VZ 3778: Update go.mod
VZ 3778: rename packages
downrev versions
Update dependencies
Revert VZ 3778: K8s 1.22 changes on hold.
…remove_repo Remove unneeded yum repo from Dockerfile
Update dependencies for OAM
…in OAM (crossplane#12) * restore finalizers during trait rendering
update xz dependency
Pull v0.3.3 changes on top of v0.3.0 release.
…yright VZ-7212 copyright license audit in 0.3.3
michael-cico
reviewed
Jan 9, 2023
@@ -1,3 +1,4 @@ | |||
//go:build !ignore_autogenerated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this intentional?
michael-cico
reviewed
Jan 9, 2023
@@ -107,6 +107,7 @@ func ValidateComponentObject(obj *v1alpha2.Component) field.ErrorList { | |||
var _ inject.Client = &ValidatingHandler{} | |||
|
|||
// InjectClient injects the client into the ComponentValidatingHandler | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like an accidental newline?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm not sure how those got added in
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or did gofmt
force these ws changes?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change user to numeric in order to ensure running as nonroot